fix: add barcode validation to image deletion and product update processes#1541
Merged
alexgarel merged 4 commits intoopenfoodfacts:mainfrom Apr 15, 2025
areebahmeddd:issues/1445/barcode-valueerror
Merged
fix: add barcode validation to image deletion and product update processes#1541alexgarel merged 4 commits intoopenfoodfacts:mainfrom areebahmeddd:issues/1445/barcode-valueerror
alexgarel merged 4 commits intoopenfoodfacts:mainfrom
areebahmeddd:issues/1445/barcode-valueerror
Conversation
github-project-automation
bot
moved this to Todo
in 🤖 Artificial Intelligence @ Open Food Facts
areebahmeddd
moved this from Todo
to In Progress
in 🤖 Artificial Intelligence @ Open Food Facts
alexgarel
reviewed
Apr 8, 2025
Member
alexgarel
left a comment
alexgarel
left a comment
There was a problem hiding this comment.
@areebahmeddd could we change the implementation ?
My proposal: add a is_valid method on ProductIdentifier
For now it will check that:
product_id is not empty, and server_type is not empty and part of ServerType.
Call this method there before processing.
This would be more exact and also more easy to generalize, and in the futur we might add more checks.
Member
Author
|
Done : ) I hope the recent commit reflects what you suggested above cc: @alexgarel |
alexgarel
approved these changes
Apr 15, 2025
Member
alexgarel
left a comment
alexgarel
left a comment
There was a problem hiding this comment.
Thank you @areebahmeddd this is good !
github-project-automation
bot
moved this from In Progress
to Done
in 🤖 Artificial Intelligence @ Open Food Facts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Areeb Ahmed (areebshariff@acm.org)
Summary of Changes
ValueErrorinupdate_insights_jobby validating empty barcodesdelete_imagesto handle deleted productsRelated Issues
Closes #1445