fix: add barcode validation to image deletion and product update processes

robotoff/images.py

@@ -203,6 +203,11 @@ def delete_images(product_id: ProductIdentifier, image_ids: list[str]):
     :param image_ids: a list of image IDs to delete.
       Each image ID must be a digit.
     """
+
+    if not product_id.is_valid():
+        logger.warning("Could not delete images, invalid product identifier")
+        return
+
     server_type = product_id.server_type.name
     # Perform batching as we don't know the number of images to delete
     updated_models = []

robotoff/types.py

@@ -283,6 +283,9 @@ def __repr__(self) -> str:
     def __hash__(self) -> int:
         return hash((self.barcode, self.server_type))
 
+    def is_valid(self) -> bool:
+        return bool(self.barcode and self.server_type)
+
 
 @enum.unique
 class ElasticSearchIndex(str, enum.Enum):

robotoff/workers/tasks/product_updated.py

@@ -30,6 +30,11 @@ def update_insights_job(product_id: ProductIdentifier, diffs: JSONType) -> None:
     """
     logger.info("Running `update_insights` for %s", product_id)
 
+    # Check for valid product identifier
+    if not product_id.is_valid():
+        logger.info("Invalid product identifier received, skipping product update")
+        return
+
     try:
         with Lock(
             name=f"robotoff:product_update_job:{product_id.server_type.name}:{product_id.barcode}",