Skip to content

Make basemap export not fail anymore when package already exists#109

Merged
gounux merged 1 commit intomasterfrom
QF-4902-fix-basemap-export-fail-when-already-existing
Mar 23, 2025
Merged

Make basemap export not fail anymore when package already exists#109
gounux merged 1 commit intomasterfrom
QF-4902-fix-basemap-export-fail-when-already-existing

Conversation

@gounux
Copy link
Member

@gounux gounux commented Mar 7, 2025

This PR makes several consecutive offline packaging to the same folder possible.

Before, the offline packager was throwing an error if the target basemap destination file was already existing, due to the underlying native:tilesxyzmbtiles processing algorithm. Which is not the case anymore.

@gounux gounux requested a review from suricactus March 7, 2025 05:18
@suricactus
Copy link
Collaborator

@gounux ping

Update libqfieldsync/offline_converter.py

Co-authored-by: Ivan Ivanov <suricactus@users.noreply.github.com>

Update libqfieldsync/offline_converter.py

Co-authored-by: Ivan Ivanov <suricactus@users.noreply.github.com>

Update libqfieldsync/offline_converter.py

Co-authored-by: Ivan Ivanov <suricactus@users.noreply.github.com>

Apply suggestion from @suricactus
@gounux gounux force-pushed the QF-4902-fix-basemap-export-fail-when-already-existing branch from 5d34060 to 9929b91 Compare March 22, 2025 17:22
@gounux
Copy link
Member Author

gounux commented Mar 22, 2025

@gounux ping

Thanks for the reminder!

@gounux gounux requested a review from suricactus March 22, 2025 17:23
@gounux gounux merged commit a9cf274 into master Mar 23, 2025
6 checks passed
@gounux gounux deleted the QF-4902-fix-basemap-export-fail-when-already-existing branch March 23, 2025 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants