Skip to content

Comments

Rename zip package on copy#143

Merged
3nids merged 1 commit intomainfrom
rename-plugin-on-copy
Feb 12, 2026
Merged

Rename zip package on copy#143
3nids merged 1 commit intomainfrom
rename-plugin-on-copy

Conversation

@domi4484
Copy link
Member

Fix #126

@domi4484 domi4484 requested a review from 3nids February 10, 2026 19:18
@github-actions
Copy link

🔌 Plugin Artifact

A development build of the plugin is available for testing:

⬇️ Download oqtopus_dev.zip

⚠️ This is a development build from commit ab4b2bd.


install_filename = os.path.join(
install_destination,
f"{self.__plugin_name}_{self.__current_module_package.name}.zip",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't id instead of name?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Name is the name of the release, the result is like that teksi_wastewater_2025.0.2.zip. There is no id inside the module package class

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added this a couple of days ago, see https://opengisch.github.io/oqtopus/adding_modules/

I have in mind that the name contains spaces, while the id is the short name.

But I am not sure which should be used in this case, so if name is working as expected, I'm perfectly fine with it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case, is the name of the package, not the module. Name should be exactly what is set in github as a release name, for example 2025.0.2 or 2025.0.2rc12.
So it can have spaces, but QGIS doesn't have problems installing from a zip file with spaces in the name.

@ponceta
Copy link
Collaborator

ponceta commented Feb 11, 2026

Great! Thank you!

Success message when we click on install
image

Package name when we click on copy zip to directory
image

@3nids 3nids merged commit 023e1d6 into main Feb 12, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

oQtopus.zip is not the best way to name the business plugin

3 participants