Skip to content

Rename zip package on copy #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
3nids merged 1 commit into from
Feb 12, 2026
Merged

Rename zip package on copy #143

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions oqtopus/gui/plugin_widget.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,14 +215,19 @@ def __copyZipToDirectoryClicked(self):
if not install_destination:
return

install_filename = os.path.join(
install_destination,
f"{self.__plugin_name}_{self.__current_module_package.name}.zip",
Copy link
Member

@3nids 3nids Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't id instead of name?

Copy link
Member Author

@domi4484 domi4484 Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Name is the name of the release, the result is like that teksi_wastewater_2025.0.2.zip. There is no id inside the module package class

Copy link
Member

@3nids 3nids Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added this a couple of days ago, see https://opengisch.github.io/oqtopus/adding_modules/

I have in mind that the name contains spaces, while the id is the short name.

But I am not sure which should be used in this case, so if name is working as expected, I'm perfectly fine with it.

Copy link
Member Author

@domi4484 domi4484 Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case, is the name of the package, not the module. Name should be exactly what is set in github as a release name, for example 2025.0.2 or 2025.0.2rc12.
So it can have spaces, but QGIS doesn't have problems installing from a zip file with spaces in the name.

)

# Copy the plugin package to the selected directory
try:
shutil.copy2(asset_plugin.package_zip, install_destination)
shutil.copy2(asset_plugin.package_zip, install_filename)

QMessageBox.information(
self,
self.tr("Plugin copied"),
self.tr(f"Plugin package has been copied to '{install_destination}'."),
self.tr(f"Plugin package has been copied to '{install_filename}'."),
)
except Exception as e:
QMessageBox.critical(
Expand Down