PMP and wally32periph fixes#1357
Merged
jordancarlin merged 15 commits intoopenhwgroup:mainfrom Apr 14, 2025
Merged
Conversation
…the riscv-arch-test pmp64-TOR* tests. Still has known limitation in issue openhwgroup#1354, but passes tests, which are now reenabled
…removed SEIP tests from WALLY-periph-01 and put them in WALY-periph-s
Closed
| "rv64i_m/privilege/src/misalign-bne-01.S", | ||
| "rv64i_m/privilege/src/misalign-jal-01.S" | ||
| // removed because rv64gc supports Zicclsm | ||
| // commented out for now because rv64gc supports Zicclsm, but Sail does not yet. Restore when Sail supports Zicclsm. |
Member
There was a problem hiding this comment.
Sail has supported misaligned accesses since before I started working on it. We must just not have been enabling the option for it. I'll update our configuration accordingly soon (at this point going to wait for us to adopt the new config format that Sail uses).
Contributor
Author
There was a problem hiding this comment.
Let's leave the comment until we enable misaligned for Sail, and then you can take it out and get these tests running in lockstep.
tests/wally-riscv-arch-test/riscv-test-suite/rv32i_m/privilege/src/WALLY-periph-s-01.S
Outdated
Show resolved
Hide resolved
tests/wally-riscv-arch-test/riscv-test-suite/rv32i_m/privilege/src/WALLY-periph-s-01.S
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,922 @@ | |||
| /////////////////////////////////////////// | |||
| // WALLY-PERIPH-S.S | |||
| // 324 bit version including SEIP tests that require supervisor mode | |||
Member
There was a problem hiding this comment.
Suggested change
| // 324 bit version including SEIP tests that require supervisor mode | |
| // 32 bit version including SEIP tests that require supervisor mode |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially fixed Wally PMP to pass TOR tests
Fixed #1321 wally32periph failing on rv32imc
Fixed #1358 PMP needs to check mstatus.MPRV
pmp code coverage 100%