4617681: constructor of BufferedImage throws unexpected IllegalArgumentException

[prrace]

Specifying the behaviour of BufferedImage constructors for invalid dimensions is long overdue.

The behaviour for image types and sizes <= 0 is unchanged by this PR.
Also in many cases the behaviour for sizes that are too large is also unchanged.
In some cases, the behaviour is changed from "accidental" NegativeArraySizeException to a consistent IllegalArgumentException.

In no case is anything changed that would affect the possibility to construct a BufferedImage.

A test is provided to ensure the behaviour.

A CSR is provided too : https://bugs.openjdk.org/browse/JDK-8369155

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change requires CSR request JDK-8369155 to be approved

Warning

 ⚠️ Found leading lowercase letter in issue title for 4617681: constructor of BufferedImage throws unexpected IllegalArgumentException

Issues

• JDK-4617681: constructor of BufferedImage throws unexpected IllegalArgumentException (Bug - P4)
• JDK-8369155: constructor of BufferedImage throws unexpected IllegalArgumentException (CSR)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27640/head:pull/27640
$ git checkout pull/27640

Update a local copy of the PR:
$ git checkout pull/27640
$ git pull https://git.openjdk.org/jdk.git pull/27640/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27640

View PR using the GUI difftool:
$ git pr show -t 27640

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27640.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back prr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@prrace The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (8a3d18ee)

[mrserb]

This check seems too strict. It is possible to implement a BufferedImage that splits its internal data into multiple surfaces/arrays. It might be better to phrase this as optional:
“for the specified format exceeds the maximum supported length”