-
Notifications
You must be signed in to change notification settings - Fork 6.3k
4617681: constructor of BufferedImage throws unexpected IllegalArgumentException #27640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
prrace
wants to merge
1
commit into
openjdk:master
Choose a base branch
from
prrace:bimg
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+185
−7
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
114 changes: 114 additions & 0 deletions
114
test/jdk/java/awt/image/BufferedImage/CreateBufferedImageTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,114 @@ | ||
| /* | ||
| * Copyright (c) 2025, Oracle and/or its affiliates. All rights reserved. | ||
| * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. | ||
| * | ||
| * This code is free software; you can redistribute it and/or modify it | ||
| * under the terms of the GNU General Public License version 2 only, as | ||
| * published by the Free Software Foundation. | ||
| * | ||
| * This code is distributed in the hope that it will be useful, but WITHOUT | ||
| * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | ||
| * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | ||
| * version 2 for more details (a copy is included in the LICENSE file that | ||
| * accompanied this code). | ||
| * | ||
| * You should have received a copy of the GNU General Public License version | ||
| * 2 along with this work; if not, write to the Free Software Foundation, | ||
| * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | ||
| * | ||
| * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA | ||
| * or visit www.oracle.com if you need additional information or have any | ||
| * questions. | ||
| */ | ||
|
|
||
| import java.awt.image.BufferedImage; | ||
| import java.awt.image.IndexColorModel; | ||
| import java.awt.image.WritableRaster; | ||
| import static java.awt.image.BufferedImage.*; | ||
|
|
||
| /** | ||
| * @test | ||
| * @bug 4617681 | ||
| * @summary Verify BufferedImage Constructor behaviour with | ||
| * invalid image size and type parameters. | ||
| */ | ||
|
|
||
| public class CreateBufferedImageTest { | ||
|
|
||
| static byte[] s = new byte[16]; | ||
| static IndexColorModel icm = new IndexColorModel(8, 16, s, s, s); | ||
|
|
||
| public static void main(String args[]) { | ||
|
|
||
| test(TYPE_CUSTOM, 10); // TYPE_CUSTOM is not a valid parameter. | ||
| test(-1, 10); | ||
| test(10001, 10); | ||
|
|
||
| for (int t = TYPE_INT_RGB; t <= TYPE_BYTE_INDEXED; t++) { | ||
| test(t, 50_000); // 50_000 ^ 2 will overflow int. | ||
| } | ||
| test(TYPE_3BYTE_BGR, 30_000); // 3 * (30_000 ^ 2) will overflow int | ||
| test(TYPE_4BYTE_ABGR, 25_000); // 4 * (25_000 ^ 2) will overflow int | ||
| test(TYPE_4BYTE_ABGR_PRE, 25_000); | ||
|
|
||
| testIndexed(TYPE_INT_RGB, 10); | ||
| testIndexed(TYPE_CUSTOM, 10); | ||
| testIndexed(-1, 10); | ||
| testIndexed(10001, 10); | ||
| testIndexed(TYPE_BYTE_BINARY, 50_000); | ||
| testIndexed(TYPE_BYTE_INDEXED, 50_000); | ||
|
|
||
| // Verify that IAE is thrown if constructing using a raster with x/y != 0 | ||
| BufferedImage bi = new BufferedImage(TYPE_INT_RGB, 10, 10); | ||
| WritableRaster raster = bi.getRaster().createCompatibleWritableRaster(20, 20, 1, 1); | ||
| try { | ||
| bi = new BufferedImage(bi.getColorModel(), raster, true, null); | ||
| throw new RuntimeException("No expected exception for invalid min x/y"); | ||
| } catch (IllegalArgumentException e) { | ||
| System.out.println("Expected exception thrown for invalid raster min x/y"); | ||
| System.out.println(e); | ||
| } | ||
| } | ||
|
|
||
| static void test(int t, int sz) { | ||
| try { | ||
| new BufferedImage(sz, sz, t); | ||
| throw new RuntimeException("No expected exception for type = " + t); | ||
| } catch (IllegalArgumentException e) { | ||
| System.out.println("Expected exception thrown"); | ||
| System.out.println(e); | ||
| } catch (NegativeArraySizeException n) { | ||
| checkIsOldVersion(26, n); | ||
| } | ||
| } | ||
|
|
||
| static void testIndexed(int t, int sz) { | ||
| try { | ||
| new BufferedImage(sz, sz, t, icm); | ||
| throw new RuntimeException("No expected exception for type = " + t); | ||
| } catch (IllegalArgumentException e) { | ||
| System.out.println("Expected exception thrown"); | ||
| System.out.println(e); | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * If running on a JDK of the targetVersion or later, throw | ||
| * a RuntimeException becuase the exception argument | ||
| * should not have occured. However it is expected on | ||
| * prior versions because that was the previous behaviour. | ||
| * @param targetVersion to check | ||
| * @param t the thrown exception to print | ||
| */ | ||
| static void checkIsOldVersion(int targetVersion, Throwable t) { | ||
| String version = System.getProperty("java.version"); | ||
| version = version.split("\\D")[0]; | ||
| int v = Integer.parseInt(version); | ||
| if (v >= targetVersion) { | ||
| t.printStackTrace(); | ||
| throw new RuntimeException( | ||
| "Unexpected exception for version " + v); | ||
| } | ||
| } | ||
|
|
||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This check seems too strict. It is possible to implement a BufferedImage that splits its internal data into multiple surfaces/arrays. It might be better to phrase this as optional:
“for the specified format exceeds the maximum supported length”