Skip to content

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Jan 19, 2026

I backport this for parity with 21.0.11-oracle

Needs follow-up.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8358159 needs maintainer approval

Issue

  • JDK-8358159: Empty mode/padding in cipher transformations (Bug - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2554/head:pull/2554
$ git checkout pull/2554

Update a local copy of the PR:
$ git checkout pull/2554
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2554/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2554

View PR using the GUI difftool:
$ git pr show -t 2554

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2554.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 19, 2026

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 19, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 3ff83ec49e561c44dd99508364b8ba068274b63a 8358159: Empty mode/padding in cipher transformations Jan 19, 2026
@openjdk
Copy link

openjdk bot commented Jan 19, 2026

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Jan 19, 2026
@openjdk
Copy link

openjdk bot commented Jan 19, 2026

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 19, 2026
@mlbridge
Copy link

mlbridge bot commented Jan 19, 2026

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Jan 21, 2026

GHA action failures:
Win: build tool crash: fixpath.sh: line 427: 2423 Segmentation fault "$command"
linux: java/util/concurrent/ExecutorService/CloseTest failed with
IllegalStateException
at java.base/java.util.concurrent.ForkJoinTask.resultNow(ForkJoinTask.java:898)
at CloseTest.testShutdownBeforeClose(CloseTest.java:112)
We have seen this failing in GHA tests before.
Both unrelated, also the tests of 8359388 including this change passed.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Jan 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant