Skip to content

Conversation

@aymane-harmaz
Copy link
Member

@aymane-harmaz aymane-harmaz commented Nov 7, 2025

This PR makes it possible to reach JFR result pages and expand / collapse rule text on the JFR result overview using keyboard enter and tab keys.

focused-rule expanded-rule-using-enter-key

Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • JMC-8469: Should make rules and page heading accessible through keyboard in JFR overview page (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmc.git pull/683/head:pull/683
$ git checkout pull/683

Update a local copy of the PR:
$ git checkout pull/683
$ git pull https://git.openjdk.org/jmc.git pull/683/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 683

View PR using the GUI difftool:
$ git pr show -t 683

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/683.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 7, 2025

👋 Welcome back aharmaz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 7, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr label Nov 7, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 7, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

1 participant