Skip to content

8469: Should make rules and page heading accessible through keyboard in JFR overview page #683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

8469: Should make rules and page heading accessible through keyboard in JFR overview page #683

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...main/java/org/openjdk/jmc/flightrecorder/rules/report/html/internal/RulesHtmlToolkit.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ private static String createRuleHtml(
displayProgress, id);
}

private static final String HEADING_PATTERN = "<div id=\"{0}_group\"><div id=\"{0}_heading\" style=\"margin-left: {4}px;\" class=\"{2}\"><div onclick=\"overview.link(''{0}'');\"><img class=\"{2}_icon\" alt=\"{1}\" src=\"data:image/png;base64,{3}\"/>{1}</div></div>"; //$NON-NLS-1$
private static final String HEADING_PATTERN = "<div id=\"{0}_group\"><div id=\"{0}_heading\" style=\"margin-left: {4}px;\" class=\"{2}\" tabindex=\"0\"><div onclick=\"overview.link(''{0}'');\"><img class=\"{2}_icon\" alt=\"{1}\" src=\"data:image/png;base64,{3}\"/>{1}</div></div>"; //$NON-NLS-1$

private static String createSubHeading(String id, String name, String type, String image, int margin) {
return MessageFormat.format(HEADING_PATTERN, Encode.forHtml(id), Encode.forHtml(name), Encode.forHtml(type),
Expand Down
2 changes: 1 addition & 1 deletion ...main/resources/org/openjdk/jmc/flightrecorder/rules/report/html/internal/rule_result.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<div name="{10}" id="{0}" style="margin-left: {5}px; display: block;" class="rule {4}">
<div name="{10}_heading" id="{0}_heading" class="rule_heading">
<div name="{10}_heading" id="{0}_heading" class="rule_heading" tabindex="0">
<div name="{10}_score" id="{0}_score" class="rule_score {4}" style="display: {8};">
<div name="{10}_score_bar" id="{0}_score_bar" class="rule_bar {4}" style="width: {1}%;">&nbsp;</div>
<div name="{10}_score_value" id="{0}_score_value" class="rule_score_value">{1}</div>
Expand Down
15 changes: 15 additions & 0 deletions ...n/resources/org/openjdk/jmc/flightrecorder/rules/report/html/internal/rules_overview.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -510,6 +510,21 @@
}
}
}
document.body.addEventListener('keydown', function(e) {
if (e.key != 'Enter') return;
if (e.target.classList.contains('column_title') || e.target.classList.contains('page_heading')) {
var id = e.target.id.replace("_heading", "");
overview.link(id);
}
else if (e.target.classList.contains('rule_heading')) {
var id = e.target.id;
var loc = id.indexOf("_heading")
if (loc != -1) {
var id_to_toggle = id.slice(0, loc) + "_text";
overview.toggleVisibility(id_to_toggle, document.getElementById(id_to_toggle + "_hide"));
}
}
})
},

link : function(name) {
Expand Down