Skip to content

Conversation

@aymane-harmaz
Copy link
Member

@aymane-harmaz aymane-harmaz commented Nov 10, 2025

This PR populates the summary, explanation, and solution fields of a rule displayed in the result overview table with the actual evaluated values.

The following screenshots show the state before and after the change.

unmapped-placeholders resolved placeholders

Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • JMC-8470: Unresolved placeholders shown in JFR result overview's table mode (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmc.git pull/684/head:pull/684
$ git checkout pull/684

Update a local copy of the PR:
$ git checkout pull/684
$ git pull https://git.openjdk.org/jmc.git pull/684/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 684

View PR using the GUI difftool:
$ git pr show -t 684

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/684.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 10, 2025

👋 Welcome back aharmaz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 10, 2025

@aymane-harmaz This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8470: Unresolved placeholders shown in JFR result overview's table mode

Reviewed-by: hdafgard

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@Gunde) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the rfr label Nov 10, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 10, 2025

Webrevs

@aymane-harmaz
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 24, 2025

@aymane-harmaz
Your change (at version 580b35f) is now ready to be sponsored by a Committer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants