Skip to content

8470: Unresolved placeholders shown in JFR result overview's table mode #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

8470: Unresolved placeholders shown in JFR result overview's table mode #684

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions ...htrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/overview/ResultTableUi.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@
import org.openjdk.jmc.common.IWritableState;
import org.openjdk.jmc.common.unit.IQuantity;
import org.openjdk.jmc.flightrecorder.rules.IResult;
import org.openjdk.jmc.flightrecorder.rules.ResultToolkit;
import org.openjdk.jmc.flightrecorder.rules.TypedResult;
import org.openjdk.jmc.flightrecorder.ui.DataPageDescriptor;
import org.openjdk.jmc.flightrecorder.ui.IPageContainer;
Expand Down Expand Up @@ -222,21 +223,21 @@ public String getTextTyped(IResult IResult) {
new TypedLabelProvider<IResult>(IResult.class) {
@Override
public String getTextTyped(IResult IResult) {
return IResult.getSummary();
return ResultToolkit.populateMessage(IResult, IResult.getSummary(), false);
}
}).build();
IColumn explanationColumn = new ColumnBuilder(Messages.ResultOverview_COLUMN_EXPLANATION, "explanation", //$NON-NLS-1$
new TypedLabelProvider<IResult>(IResult.class) {
@Override
public String getTextTyped(IResult IResult) {
return IResult.getExplanation();
return ResultToolkit.populateMessage(IResult, IResult.getExplanation(), false);
}
}).build();
IColumn solutionColumn = new ColumnBuilder(Messages.ResultOverview_COLUMN_SOLUTION, "solution", //$NON-NLS-1$
new TypedLabelProvider<IResult>(IResult.class) {
@Override
public String getTextTyped(IResult IResult) {
return IResult.getSolution();
return ResultToolkit.populateMessage(IResult, IResult.getSolution(), false);
}
}).build();
IColumn idColumn = new ColumnBuilder(Messages.ResultOverview_COLUMN_RESULT_ID, "id", //$NON-NLS-1$
Expand Down