generated from openmcp-project/repository-template
-
Notifications
You must be signed in to change notification settings - Fork 1
chore: simplify codebase #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
3ecb5c0
docs: add comments
maximiliantech 0c61f9e
chore: update generated files
maximiliantech f6182ab
feat: add environment variable to properly read kubeconfig
maximiliantech bb3a863
chore: update .gitignore
maximiliantech a9017a1
chore: update build repo
maximiliantech 0a345a3
feat(fixme): use openmcp-operator/api
maximiliantech 4c51ff2
docs: add code comments
maximiliantech 0efc99f
chore: update build repo
maximiliantech a8caafd
Merge branch 'main' into feat/improvements
maximiliantech 2edfb25
docs: add more comments
maximiliantech 11bc79a
test: add context_test.go
maximiliantech f44b445
test: add more tests
maximiliantech 8e986d3
refactor: code
maximiliantech 3118a93
test: increase coverage
maximiliantech 9156be6
test(smartrequeue): increase coverage to 90%
maximiliantech cc45273
fix(example): typo
maximiliantech 542931d
fix: phase declaration
maximiliantech b206a94
chore: remove errors
maximiliantech 46a61b6
chore: update PROJECT file
maximiliantech 28f20e7
chore: register openmcp-operator v1alpha1 scheme
maximiliantech 2dbc389
chore: update sample
maximiliantech 60ba74b
docs: add todo
maximiliantech ce79040
fix: imports
maximiliantech 1072ccb
Merge branch 'main' into feat/improvements
maximiliantech File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -27,3 +27,6 @@ go.work | |
| *~ | ||
|
|
||
| *.html | ||
|
|
||
| # VS Code Go debug binaries | ||
| bin/debug_bin* | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason we don't use the common definition from openmcp-operator instead of re-defining things here?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I will do that step by step with the next PRs. Right now, the
Clusterresource in the openmcp-operator does not support Conditions frommetav1.[]Conditionyet. It is a temporary solution until the openmcp-operator fully incorporates our latest API decisions.