Skip to content

Conversation

@maximiliantech
Copy link
Member

@maximiliantech maximiliantech commented May 28, 2025

What this PR does / why we need it:
This PR adds:

  • code comments for interfaces and their implementation
  • introducing feature to read kubeconfigs properly in production and dev environments
  • removes the AccessRequest API and instead using the implementation from https://github.com/openmcp-project/openmcp-operator/blob/main/api/clusters/v1alpha1/accessrequest_types.go
  • Keeping the Cluster API implementation since the openmcp-operator is not yet using the correct underlying structs
  • go.mod: updates go version to 1.24.3
  • go.mod: updates direct and indirect dependencies
  • refactor the pkg/smartrequeue package
  • add more unit tests in the pkg/... directories
  • remove end-to-end test suite as this is not needed right now

Which issue(s) this PR fixes:
Related issue: openmcp-project/backlog#11
First attempt to fix #26

Special notes for your reviewer:

Release note:

Upgrading go.mod version, direct and indirect dependencies
Introducing feature to read kubeconfigs properly in production and dev environments
Refactor smartrequeue package for better legibility and add more unit tests 

@maximiliantech maximiliantech marked this pull request as ready for review July 16, 2025 14:15
Copy link
Contributor

@reshnm reshnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM.
Just one question regarding the type definitions.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason we don't use the common definition from openmcp-operator instead of re-defining things here?

Copy link
Member Author

@maximiliantech maximiliantech Jul 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I will do that step by step with the next PRs. Right now, the Cluster resource in the openmcp-operator does not support Conditions from metav1.[]Condition yet. It is a temporary solution until the openmcp-operator fully incorporates our latest API decisions.

@maximiliantech maximiliantech changed the title feat: simplify setup chore: simplify codebase Jul 16, 2025
@maximiliantech maximiliantech enabled auto-merge (squash) July 16, 2025 15:55
@maximiliantech maximiliantech disabled auto-merge July 16, 2025 15:55
@maximiliantech maximiliantech merged commit 88376fa into main Jul 17, 2025
7 checks passed
@maximiliantech maximiliantech deleted the feat/improvements branch July 17, 2025 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use common types from openmcp-operator

4 participants