-
Notifications
You must be signed in to change notification settings - Fork 1
chore: simplify codebase #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM.
Just one question regarding the type definitions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason we don't use the common definition from openmcp-operator instead of re-defining things here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I will do that step by step with the next PRs. Right now, the Cluster resource in the openmcp-operator does not support Conditions from metav1.[]Condition yet. It is a temporary solution until the openmcp-operator fully incorporates our latest API decisions.
What this PR does / why we need it:
This PR adds:
AccessRequestAPI and instead using the implementation from https://github.com/openmcp-project/openmcp-operator/blob/main/api/clusters/v1alpha1/accessrequest_types.goClusterAPI implementation since the openmcp-operator is not yet using the correct underlying structsgo.mod: updates go version to 1.24.3go.mod: updates direct and indirect dependenciespkg/smartrequeuepackagepkg/...directoriesWhich issue(s) this PR fixes:
Related issue: openmcp-project/backlog#11
First attempt to fix #26
Special notes for your reviewer:
Release note: