Skip to content

fix: fix the templating of image pull secrets #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 11, 2025
Merged

fix: fix the templating of image pull secrets #4

merged 2 commits into from
Sep 11, 2025

Conversation

@reshnm
Copy link
Contributor

@reshnm reshnm commented Sep 11, 2025

  • The image pull secrets were not correctly rendered
  • Add image pull secrets for deployments in the openmcp kustomization
  • Replace deprecated serviceAccount with serviceAccountName

@reshnm reshnm requested a review from n3rdc4ptn September 11, 2025 09:39
n3rdc4ptn
n3rdc4ptn approved these changes Sep 11, 2025
View reviewed changes
Copy link
Member

@n3rdc4ptn n3rdc4ptn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@reshnm reshnm merged commit ca41867 into main Sep 11, 2025
3 of 4 checks passed
@n3rdc4ptn n3rdc4ptn deleted the fix/templating branch September 11, 2025 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@n3rdc4ptn n3rdc4ptn n3rdc4ptn approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@reshnm @n3rdc4ptn