Skip to content

fix: fix the templating of image pull secrets #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 11, 2025
Merged

fix: fix the templating of image pull secrets #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9226b19
fix: fix the templating of image pull secrets
reshnm Sep 11, 2025
1ddd6ab
feat: release v0.0.6
reshnm Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion VERSION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v0.0.5-dev
v0.0.6
2 changes: 1 addition & 1 deletion templates/fluxcd/templates/resources/kustomization.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,5 +37,5 @@ patches:
template:
spec:
imagePullSecrets:
{{ toYaml .Values.imagePullSecrets | indent 8 }}
{{ toYaml .Values.imagePullSecrets | indent 14 }}
{{- end }}
2 changes: 1 addition & 1 deletion templates/openmcp/templates/resources/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ spec:
labels:
app: openmcp-operator
spec:
serviceAccount: openmcp-operator
serviceAccountName: openmcp-operator
initContainers:
- name: openmcp-operator-init
image: <openmcp/openmcp-operator>:latest
Expand Down
17 changes: 17 additions & 0 deletions templates/openmcp/templates/resources/kustomization.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,20 @@ resources:
- rbac.yaml
- namespace.yaml
- deployment.yaml

{{- if .Values.imagePullSecrets }}
patches:
- target:
kind: Deployment
patch: |
apiVersion: apps/v1
kind: Deployment
metadata:
name: this_value_is_ignored
spec:
template:
spec:
imagePullSecrets:
{{ toYaml .Values.imagePullSecrets | indent 14 }}
{{- end }}

Loading