generated from openmcp-project/repository-template
-
Notifications
You must be signed in to change notification settings - Fork 2
Implement v2 bridge #103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Implement v2 bridge #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reshnm
reviewed
Jul 15, 2025
reshnm
reviewed
Jul 15, 2025
|
Requires a controller-utils release containing openmcp-project/controller-utils#91. |
ValentinGerlach
approved these changes
Jul 28, 2025
|
|
||
| // instead of calling a handler, create a ClusterRequest and an AccessRequest | ||
| // ensure namespace, because this is created on the platform cluster | ||
| nsName := openmcpclusterutils.StableRequestNamespace(as.Namespace) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Follow up: Let's think about a different approach that does not exceed the 63 character limit of DNS subdomains.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Enables the usage of the Gardener ClusterProvider for cluster creation (v2 architecture) instead of the internal logic (v1 architecture).
Adds general logic for switching between v1 and v2 architecture for specific components.
Which issue(s) this PR fixes:
Part of openmcp-project/backlog#104
Special notes for your reviewer:
Release note: