chore: Migrate the repo to use taskfiles and centralized github actions #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximiliantech
requested changes
Jun 25, 2025
There was a problem hiding this comment.
I can see that the CRDs will be generated in cmd/metrics-operator/embedded/crds but why do they get also generated in cmd/embedded/crds? Is that really needed? Could you please have a look?
There was a problem hiding this comment.
You are correct, I missed them while cleaning up!
moelsayed
commented
Jun 25, 2025
| @@ -0,0 +1 @@ | |||
| ../../cmd/metrics-operator/embedded/crds/ No newline at end of file | |||
There was a problem hiding this comment.
We opted to symlink this instead of generating the files twice, this decision was made here.
maximiliantech
approved these changes
Jun 27, 2025
Closed
maximiliantech
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR migrates the repository to use Taskfiles for local development automation and centralizes GitHub Actions workflows. By adopting Taskfiles, contributors can benefit from standardized development, build, and test commands, making onboarding and collaboration easier. Centralizing GitHub Actions ensures that CI/CD workflows are consistent, maintainable, and easier to update across the project.
Which issue(s) this PR fixes:
Fixes #42
Special notes for your reviewer:
Release note: