feat: add RoleRefs to AccessRequest API #128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximiliantech
requested review from
Diaphteiros,
ValentinGerlach,
reshnm and
robertgraeff
reshnm
approved these changes
Aug 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds the new field
RoleRefsto theAccessRequestAPI. This is needed for Cluster Providers. They will createServiceAccounts,(Cluster)Rolesand(Cluster)RoleBindings. With this feature, they can configure that the service account on the MCP will be bound to an existing(Cluster)Rolee.g. "cluster-admin".Which issue(s) this PR fixes:
Related openmcp-project/service-provider-crossplane#21
Special notes for your reviewer:
NONE
Release note: