chore: Use shared Task definitions #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
3 tasks
Diaphteiros
requested changes
Apr 30, 2025
Taskfile.yaml
Outdated
Comment on lines
26
to
39
| common: # imported a second time so that overwriting task definitions can call the overwritten task with a 'c:' prefix | ||
| taskfile: hack/common/Taskfile_controller.yaml | ||
| internal: true | ||
| aliases: | ||
| - c | ||
| vars: | ||
| NESTED_MODULES: api | ||
| API_DIRS: '{{.ROOT_DIR}}/api/v1alpha1/...' | ||
| MANIFEST_OUT: '{{.ROOT_DIR}}/api/crds/manifests' | ||
| CODE_DIRS: '{{.ROOT_DIR}}/cmd/... {{.ROOT_DIR}}/api/v1alpha1/... {{.ROOT_DIR}}/api/install/... {{.ROOT_DIR}}/api/crds/...' | ||
| COMPONENTS: 'quota-operator' | ||
| REPO_URL: 'https://github.com/openmcp-project/quota-operator' | ||
| GENERATE_DOCS_INDEX: "true" | ||
| ENVTEST_REQUIRED: "true" |
There was a problem hiding this comment.
Suggested change
| common: # imported a second time so that overwriting task definitions can call the overwritten task with a 'c:' prefix | |
| taskfile: hack/common/Taskfile_controller.yaml | |
| internal: true | |
| aliases: | |
| - c | |
| vars: | |
| NESTED_MODULES: api | |
| API_DIRS: '{{.ROOT_DIR}}/api/v1alpha1/...' | |
| MANIFEST_OUT: '{{.ROOT_DIR}}/api/crds/manifests' | |
| CODE_DIRS: '{{.ROOT_DIR}}/cmd/... {{.ROOT_DIR}}/api/v1alpha1/... {{.ROOT_DIR}}/api/install/... {{.ROOT_DIR}}/api/crds/...' | |
| COMPONENTS: 'quota-operator' | |
| REPO_URL: 'https://github.com/openmcp-project/quota-operator' | |
| GENERATE_DOCS_INDEX: "true" | |
| ENVTEST_REQUIRED: "true" |
This part should only be needed if we overwrite tasks in this file and need to refer to the original implementation, which is not the case.
Taskfile.yaml
Outdated
| CODE_DIRS: '{{.ROOT_DIR}}/cmd/... {{.ROOT_DIR}}/api/v1alpha1/... {{.ROOT_DIR}}/api/install/... {{.ROOT_DIR}}/api/crds/...' | ||
| COMPONENTS: 'quota-operator' | ||
| REPO_URL: 'https://github.com/openmcp-project/quota-operator' | ||
| GENERATE_DOCS_INDEX: "true" |
There was a problem hiding this comment.
We should either configure this so that it doesn't create an empty documentation index or disable it for now, see my comment here openmcp-project/project-workspace-operator#36 (comment) for further information.
Taskfile.yaml
Outdated
| COMPONENTS: 'quota-operator' | ||
| REPO_URL: 'https://github.com/openmcp-project/quota-operator' | ||
| GENERATE_DOCS_INDEX: "true" | ||
| ENVTEST_REQUIRED: "true" |
There was a problem hiding this comment.
Suggested change
| ENVTEST_REQUIRED: "true" |
The quota operator doesn't use tests which require envtest, so this can be removed.
docs/README.md
Outdated
There was a problem hiding this comment.
If we decide to disable documentation index generation for now, this file has to be removed. Otherwise, the generation should fill it with at least some content.
guewa
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
This PR changes the artifact paths from
ghcr.io/openmcp-project/github.com/openmcp-project/...toghcr.io/openmcp-project/....Release note: