Toast notification display fix and form improvements #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hubert-Szczepanski-SAP
previously approved these changes
Mar 24, 2025
andreaskienle
requested changes
Mar 24, 2025
enrico-kaack-comp
previously approved these changes
Mar 24, 2025
…mcp-project/ui-frontend into bugfix/toast-and-form-fixes
lucasgoral
dismissed stale reviews from enrico-kaack-comp and Hubert-Szczepanski-SAP
via
5964485
andreaskienle
approved these changes
Mar 24, 2025
There was a problem hiding this comment.
Looks good! Just for my own curiosity:
- Why aren’t we using
reset()to reset the entire form instead of resetting each field separately? - I might be missing something, but could we use
defaultValuesinuseFormto prefill the email address instead of doing it in useEffect? Then, we could just call reset(defaultValues)whenisOpenchanges. If this works, it might make the code easier to follow. But we can also leave it like it is, it just crossed my mind.
Anyway, thanks for resolving the issue so swiftly! 😊
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR fixes toast notification text that was not displayed fully and adds small improvement to the create project form.