Skip to content

Toast notification display fix and form improvements #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 25, 2025
Merged

Toast notification display fix and form improvements #17

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9216e36
fixes
lucasgoral Mar 24, 2025
abff7f4
Merge branch 'main' into bugfix/toast-and-form-fixes
lucasgoral Mar 24, 2025
e72c720
Merge branch 'main' into bugfix/toast-and-form-fixes
lucasgoral Mar 24, 2025
bd0aa93
form fix
lucasgoral Mar 24, 2025
5964485
Merge branch 'bugfix/toast-and-form-fixes' of https://github.com/open…
lucasgoral Mar 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/components/Dialogs/CreateProjectDialogContainer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export function CreateProjectDialogContainer({
const {
register,
handleSubmit,
reset,
resetField,
setValue,
formState: { errors },
watch,
Expand All @@ -57,9 +57,6 @@ export function CreateProjectDialogContainer({
{ name: username, roles: [MemberRoles.admin], kind: 'User' },
]);
}
return () => {
reset();
};
}, []);

const toast = useToast();
Expand All @@ -86,6 +83,9 @@ export function CreateProjectDialogContainer({
);
setIsOpen(false);
toast.show(t('CreateProjectDialog.toastMessage'));
resetField('name');
resetField('chargingTarget');
resetField('displayName');
return true;
} catch (e) {
console.error(e);
Expand Down
5 changes: 5 additions & 0 deletions src/index.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,4 +107,9 @@ body {

ui5-form-item {
margin-bottom: 24px;
}

ui5-toast {
width: 50ch;
max-width: 100%;
}