Add basic GH Actions #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.github/workflows/build.yaml
Outdated
| node-version: 22 | ||
|
|
||
| - name: Install dependencies | ||
| run: npm i |
There was a problem hiding this comment.
In a pipeline I think npm ci would be better. But our lockfile should then be reliable. And I’m not sure about that, as there are bun.lock, package-lock.json and yarn.lock 🤯
Could also leave it like this for now (npm i in the pipeline) but I think we should eventually decide on one package manager.
There was a problem hiding this comment.
good spot thank you, I changed it to npm ci. I will also follow up on a ticket with deciding for one package manager.
andreaskienle
approved these changes
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This Pr introduces a simple build step in the pipeline on PR opened/synchronize.
Will be later expanded with tests, linting etc.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: