Skip to content

Add basic GH Actions #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 18, 2025
Merged

Add basic GH Actions #4

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b32fbd8
add basic build step
enrico-kaack-comp Mar 18, 2025
60bd4a5
change to npm ci
enrico-kaack-comp Mar 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions .github/workflows/build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
name: Build

on:
workflow_call:

jobs:
build:
runs-on: ubuntu-latest

steps:
- name: Checkout code
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2

- name: Set up Node.js
uses: actions/setup-node@cdca7365b2dadb8aad0a33bc7601856ffabcc48e # v4.3.0
with:
node-version: 22

- name: Install dependencies
run: npm i
Copy link
Contributor

@andreaskienle andreaskienle Mar 18, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a pipeline I think npm ci would be better. But our lockfile should then be reliable. And I’m not sure about that, as there are bun.lock, package-lock.json and yarn.lock 🤯

Could also leave it like this for now (npm i in the pipeline) but I think we should eventually decide on one package manager.

Copy link
Contributor Author

@enrico-kaack-comp enrico-kaack-comp Mar 18, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good spot thank you, I changed it to npm ci. I will also follow up on a ticket with deciding for one package manager.


- name: Build
run: npm run build
63 changes: 0 additions & 63 deletions .github/workflows/build.yml
View file
Open in desktop

This file was deleted.

11 changes: 11 additions & 0 deletions .github/workflows/on-pr.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
name: On Pull Request

on:
pull_request:
types:
- opened
- synchronize

jobs:
build:
uses: ./.github/workflows/build.yaml