Skip to content

feat: allow dots in StringMapInput type #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Aug 5, 2025

Conversation

aaronschweig
Copy link
Member

@aaronschweig aaronschweig commented Aug 4, 2025

Allow dots in input object with the introduction of a StrinMapInput type that takes key values pairs as arguments, but still returns the labels normally

Screenshot 2025-08-04 at 14 26 20

@aaronschweig aaronschweig requested a review from a team as a code owner August 4, 2025 12:25
@aaronschweig aaronschweig changed the title feat: allow dots in StrinMap Input type feat: allow dots in StringMapInput type Aug 4, 2025
On-behalf-of: @SAP [email protected]
Signed-off-by: Artem Shcherbatiuk <[email protected]>
On-behalf-of: @SAP [email protected]
Signed-off-by: Artem Shcherbatiuk <[email protected]>
On-behalf-of: @SAP [email protected]
Signed-off-by: Artem Shcherbatiuk <[email protected]>
On-behalf-of: @SAP [email protected]
Signed-off-by: Artem Shcherbatiuk <[email protected]>
@vertex451
Copy link
Member

Testing

Created a configMap with labels as variables.
Note: GraphQL playground's variables section show validation error because it doesn't understand StringMapInput type, but it works.

Screenshot 2025-08-04 at 20 01 55

@vertex451 vertex451 self-assigned this Aug 5, 2025
@vertex451 vertex451 added this to the 2025.Q3 milestone Aug 5, 2025
@aaronschweig aaronschweig merged commit c2a3474 into main Aug 5, 2025
12 checks passed
@aaronschweig aaronschweig deleted the feat/allow-dots-in-string-map-input branch August 5, 2025 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants