(feat): Hiding the patient banner#135
Merged
samuelmale merged 4 commits intoopenmrs:mainfrom Aug 26, 2025
Merged
Conversation
This was referenced Aug 17, 2025
Contributor
Author
|
CC @samuelmale |
Member
|
Can you split this PR into two?
|
Twiineenock
changed the title
Contributor
Author
|
Hi @samuelmale |
samuelmale
reviewed
Aug 25, 2025
src/patient-card/PatientCard.tsx
Outdated
| <CheckmarkOutline size={16} className={styles.statusSuccess} /> | ||
| ) : ( | ||
| <WarningAlt size={16} className={styles.statusWarning} /> | ||
| <DocumentBlank size={16} className={styles.statusWarning} /> |
Member
There was a problem hiding this comment.
@Twiineenock I think we should keep the WarningAlt until we get some concrete UX advice.
Contributor
Author
There was a problem hiding this comment.
Alright @samuelmale,
Reverted the changes to that file.
samuelmale
approved these changes
Aug 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR includes the following updates:
patient-header-slot.WarningAlticon with theDocumentBlankicon.Screenshots
Before
Double Patient Banner
Rude icon for unsubmitted forms
After
Related Issue
Other
Related Pull Requests
openmrs-esm-form-engine-lib
openmrs-esm-patient-chart