(feat) Add prop to toggle patient banner rendering#624
Merged
samuelmale merged 2 commits intoopenmrs:mainfrom Aug 20, 2025
Merged
(feat) Add prop to toggle patient banner rendering#624samuelmale merged 2 commits intoopenmrs:mainfrom
samuelmale merged 2 commits intoopenmrs:mainfrom
Conversation
This was referenced Aug 17, 2025
Contributor
Author
|
CC @samuelmale |
samuelmale
reviewed
Aug 19, 2025
src/form-engine.component.tsx
Outdated
| } = useFormJson(formUUID, formJson, encounterUUID, formSessionIntent, preFilledQuestions); | ||
|
|
||
| const showPatientBanner = useMemo(() => { | ||
| if (hidePatientBanner) return false; |
Member
There was a problem hiding this comment.
Suggested change
| if (hidePatientBanner) return false; | |
| if (hidePatientBanner) { | |
| return false; | |
| } |
samuelmale
changed the title
samuelmale
approved these changes
Aug 20, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Currently, the patient banner visibility can only be toggled in workspace zones. However, there are other non-workspace zones, such as the FDE, where we also want this flexibility. This PR introduces a new
hidePatientBannerprop, which defaults tofalse, allowing the banner to be hidden in these additional contexts.Screenshots
Related Issue
Other
Related Pull Requests
openmrs-esm-patient-chart
openmrs-esm-fast-data-entry-app