O3-4418: Fix tooltip clipping and prevent unintended accordion collapse#1093
O3-4418: Fix tooltip clipping and prevent unintended accordion collapse#1093BHUVANSH855 wants to merge 6 commits intoopenmrs:mainfrom
Conversation
…se in draggable question actions
|
Hi @VeronicaMuthee @denniskigen @ibacher 👋, This PR addresses O3-4418 by fixing tooltip clipping in the Interactive Builder and preventing unintended accordion collapse when clicking action buttons. I’ve tested the changes at multiple zoom levels (100%, 125%, 150%), and all tests are passing locally. Kindly requesting a review. Thank you! |
|
hi @BHUVANSH855 great work , could you paste the screenrecording before and after . |
Hi @sourav-jyoti 👋 Thank you for the suggestion. I’ve added the screen recordings in the PR description. In the Before video, the behavior is shown at zoom levels 100%, 125%, and 150%, where tooltip clipping and unintended accordion collapse are visible. In the After video, the same zoom levels (100%, 125%, and 150%) are demonstrated, showing that the tooltip displays correctly and the accordion no longer collapses when clicking action buttons. Kindly review and let me know if any further adjustments are needed. Thank you! |
|
Hi @sourav-jyoti, Anu updates... |
@BHUVANSH855 , currently a new version of o3 is being relaease and senior reviewers are busy there , so don't worry ur pr will be reviewed soon |
|
Can we reduce this down the minimal set of changes you're proposing here? |
Hi @ibacher 👋 Thanks for the feedback. The changes in this PR are focused specifically on two things:
The modifications are scoped only to these areas to ensure the fix works correctly across different interaction points and zoom levels. No unrelated logic or structural refactoring is intended. If you feel there’s a particular part that can be simplified further while preserving the fix, I’d be happy to adjust it accordingly. Thank you for the review! |
| handleDuplicateQuestion, | ||
| onSchemaChange, | ||
| pageIndex, | ||
| sectionIndex, | ||
| question, | ||
| questionCount, | ||
| questionIndex, | ||
| subQuestionIndex: subQuestionIndex ?? null, | ||
| schema, |
There was a problem hiding this comment.
you can revert back this changes to decrease the no of changes, as this doesn't effect the issue
There was a problem hiding this comment.
Thanks @sourav-jyoti for your suggestions, I did it kindly review.
Description
This PR addresses O3-4418 by fixing tooltip clipping issues in the Interactive Form Builder and preventing unintended accordion collapse when action buttons inside draggable questions are clicked.
Previously:
Changes Made
Testing
Screen Recordings
Screen.Recording.2026-02-24.130540.mp4
Screen.Recording.2026-02-24.130718.mp4
Closes O3-4418.