Skip to content

O3-4418: Fix tooltip clipping and prevent unintended accordion collapse#1093

Open
BHUVANSH855 wants to merge 6 commits intoopenmrs:mainfrom
BHUVANSH855:fix/O3-4418-tooltip-alignment
Open

O3-4418: Fix tooltip clipping and prevent unintended accordion collapse#1093
BHUVANSH855 wants to merge 6 commits intoopenmrs:mainfrom
BHUVANSH855:fix/O3-4418-tooltip-alignment

Conversation

@BHUVANSH855
Copy link

@BHUVANSH855 BHUVANSH855 commented Feb 23, 2026

Description

This PR addresses O3-4418 by fixing tooltip clipping issues in the Interactive Form Builder and preventing unintended accordion collapse when action buttons inside draggable questions are clicked.

Previously:

  • Tooltips were partially clipped or hidden at higher browser zoom levels (125%, 150%) due to stacking context issues.
  • Clicking action buttons (Duplicate, Edit, Delete) unintentionally triggered the parent accordion collapse because click events were bubbling to the container.

Changes Made

  • Restored proper drag handle behavior using the Draggable icon.
  • Prevented action button clicks from triggering accordion collapse.
  • Fixed tooltip clipping by resolving stacking context conflicts.
  • Cleaned up the draggable question structure for clearer separation between drag controls and action buttons.
  • Minor refactor to improve component clarity and maintainability.

Testing

  • Verified tooltip alignment and visibility at 100%, 125%, and 150% zoom levels.
  • Confirmed that accordion only collapses when explicitly intended.
  • Ran full test suite (19 test suites, 103 tests — all passing).
  • Lint and TypeScript checks passed successfully.

Screen Recordings

  • Before
Screen.Recording.2026-02-24.130540.mp4
  • After
Screen.Recording.2026-02-24.130718.mp4

Closes O3-4418.

@BHUVANSH855
Copy link
Author

BHUVANSH855 commented Feb 23, 2026

Hi @VeronicaMuthee @denniskigen @ibacher 👋,

This PR addresses O3-4418 by fixing tooltip clipping in the Interactive Builder and preventing unintended accordion collapse when clicking action buttons.

I’ve tested the changes at multiple zoom levels (100%, 125%, 150%), and all tests are passing locally.

Kindly requesting a review. Thank you!

@sourav-jyoti
Copy link
Contributor

hi @BHUVANSH855 great work , could you paste the screenrecording before and after .

@BHUVANSH855
Copy link
Author

hi @BHUVANSH855 great work , could you paste the screenrecording before and after .

Hi @sourav-jyoti 👋

Thank you for the suggestion.

I’ve added the screen recordings in the PR description.

In the Before video, the behavior is shown at zoom levels 100%, 125%, and 150%, where tooltip clipping and unintended accordion collapse are visible.

In the After video, the same zoom levels (100%, 125%, and 150%) are demonstrated, showing that the tooltip displays correctly and the accordion no longer collapses when clicking action buttons.

Kindly review and let me know if any further adjustments are needed.

Thank you!

@BHUVANSH855
Copy link
Author

Hi @sourav-jyoti,

Anu updates...

@sourav-jyoti
Copy link
Contributor

Hi @sourav-jyoti,

Anu updates...

@BHUVANSH855 , currently a new version of o3 is being relaease and senior reviewers are busy there , so don't worry ur pr will be reviewed soon

@ibacher
Copy link
Member

ibacher commented Feb 27, 2026

Can we reduce this down the minimal set of changes you're proposing here?

@BHUVANSH855
Copy link
Author

Can we reduce this down the minimal set of changes you're proposing here?

Hi @ibacher 👋

Thanks for the feedback.

The changes in this PR are focused specifically on two things:

  1. Preventing unintended accordion collapse by stopping event propagation from the action buttons (Duplicate, Edit, Delete, Drag, and Collapse icon).

  2. Fixing tooltip clipping by adjusting the tooltip z-index.

The modifications are scoped only to these areas to ensure the fix works correctly across different interaction points and zoom levels. No unrelated logic or structural refactoring is intended.

If you feel there’s a particular part that can be simplified further while preserving the fix, I’d be happy to adjust it accordingly.

Thank you for the review!

Comment on lines +79 to +87
handleDuplicateQuestion,
onSchemaChange,
pageIndex,
sectionIndex,
question,
questionCount,
questionIndex,
subQuestionIndex: subQuestionIndex ?? null,
schema,
Copy link
Contributor

@sourav-jyoti sourav-jyoti Feb 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can revert back this changes to decrease the no of changes, as this doesn't effect the issue

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sourav-jyoti for your suggestions, I did it kindly review.

@BHUVANSH855 BHUVANSH855 requested a review from sourav-jyoti March 3, 2026 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants