Skip to content

O3-4418: Fix tooltip clipping and prevent unintended accordion collapse #1093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BHUVANSH855 wants to merge 6 commits into
base: main
Choose a base branch
from
Open

O3-4418: Fix tooltip clipping and prevent unintended accordion collapse #1093

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ed20bcc
O3-4418: Fix tooltip clipping and prevent unintended accordion collap…
BHUVANSH855 Feb 23, 2026
023049e
Merge branch 'main' into fix/O3-4418-tooltip-alignment
BHUVANSH855 Feb 24, 2026
4290893
Merge branch 'main' into fix/O3-4418-tooltip-alignment
BHUVANSH855 Feb 24, 2026
7a4e8ad
Revert unnecessary subQuestionIndex change and simplify object notation
BHUVANSH855 Feb 28, 2026
ef38796
Merge branch 'main' into fix/O3-4418-tooltip-alignment
BHUVANSH855 Mar 2, 2026
f19d502
Merge branch 'main' into fix/O3-4418-tooltip-alignment
BHUVANSH855 Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 23 additions & 13 deletions src/components/interactive-builder/draggable/draggable-question.component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,15 +75,15 @@ const DraggableQuestion: React.FC<DraggableQuestionProps> = ({
data: {
type: subQuestionIndex === null || subQuestionIndex === undefined ? 'question' : 'obsQuestion',
question: {
handleDuplicateQuestion: handleDuplicateQuestion,
onSchemaChange: onSchemaChange,
pageIndex: pageIndex,
sectionIndex: sectionIndex,
question: question,
questionCount: questionCount,
questionIndex: questionIndex,
subQuestionIndex: subQuestionIndex !== null ? subQuestionIndex : null,
schema: schema,
handleDuplicateQuestion,
onSchemaChange,
pageIndex,
sectionIndex,
question,
questionCount,
questionIndex,
subQuestionIndex,
schema,
Comment on lines +78 to +86
Copy link
Contributor

@sourav-jyoti sourav-jyoti Feb 28, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can revert back this changes to decrease the no of changes, as this doesn't effect the issue

Copy link
Author

@BHUVANSH855 BHUVANSH855 Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sourav-jyoti for your suggestions, I did it kindly review.

},
},
disabled: questionCount <= 1 && (subQuestionIndex === undefined || subQuestionIndex === null),
Expand Down Expand Up @@ -123,6 +123,7 @@ const DraggableQuestion: React.FC<DraggableQuestionProps> = ({
label={t('dragToReorder', 'Drag to reorder')}
kind="ghost"
size="md"
onClick={(e) => e.stopPropagation()}
>
<Draggable />
</IconButton>
Expand All @@ -140,7 +141,10 @@ const DraggableQuestion: React.FC<DraggableQuestionProps> = ({
enterDelayMs={defaultEnterDelayInMs}
label={t('duplicateQuestion', 'Duplicate question')}
kind="ghost"
onClick={handleDuplicate}
onClick={(e) => {
e.stopPropagation();
handleDuplicate();
}}
size="md"
>
<Copy />
Expand All @@ -149,7 +153,10 @@ const DraggableQuestion: React.FC<DraggableQuestionProps> = ({
enterDelayMs={defaultEnterDelayInMs}
label={t('editQuestion', 'Edit question')}
kind="ghost"
onClick={launchEditQuestionModal}
onClick={(e) => {
e.stopPropagation();
launchEditQuestionModal();
}}
size="md"
>
<Edit />
Expand All @@ -158,13 +165,16 @@ const DraggableQuestion: React.FC<DraggableQuestionProps> = ({
enterDelayMs={defaultEnterDelayInMs}
label={t('deleteQuestion', 'Delete question')}
kind="ghost"
onClick={launchDeleteQuestionModal}
onClick={(e) => {
e.stopPropagation();
launchDeleteQuestionModal();
}}
size="md"
>
<TrashCan />
</IconButton>
{question?.questions && question?.questions.length > 0 && (
<span className={styles.collapseIconWrapper}>
<span className={styles.collapseIconWrapper} onClick={(e) => e.stopPropagation()}>
{isCollapsed ? (
<ChevronDownIcon className={styles.collapseIcon} aria-label="Expand" />
) : (
Expand Down
2 changes: 1 addition & 1 deletion src/components/interactive-builder/interactive-builder.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
}

:global(.cds--tooltip) {
z-index: 1;
z-index: 9999 !important;
}
}

Expand Down