O3-4814 Appointments: Show patients with all statuses in one big appointments table; remove status selector bar; add status filter dropdown by EDSONZ-WASSWA · Pull Request #2151 · openmrs/openmrs-esm-patient-management

EDSONZ-WASSWA · 2025-12-05T11:05:36Z

Requirements

This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
My work is based on designs, which are linked or shown either in the Jira ticket or the description below.
My work includes tests or is validated by existing tests.

Summary

Worked on the Appointments table,
Instead showing appointments with all statuses in one table. That table then has a “Filter by status” dropdown.

Screenshots

After

fixed-Add "All" status filter option

before

Related Issue

Other

One PR for both tickets below
https://openmrs.atlassian.net/browse/O3-4815
https://openmrs.atlassian.net/issues/?filter=-1&selectedIssue=O3-4814

denniskigen · 2025-12-08T11:57:46Z

Could you review this when you get the chance, @brandones?

brandones · 2025-12-08T14:22:15Z

Sure, thanks for the ping @denniskigen .

@EDSONZ-WASSWA could you please make the default status in the filter dropdown "All"? When "All" is selected, the table should include a column showing the status. Let me know if you need clarification.

…statuses-in-one-big-appointments-table-remove-status-selector-bar-add-status-filter-dropdown

EDSONZ-WASSWA · 2025-12-08T22:15:40Z

@brandones I have made the fix as you requested

brandones · 2025-12-09T15:33:11Z

@EDSONZ-WASSWA this looks obviously bad

It looks like there are a bunch of style overrides that are probably causing problems. Much like human newbie devs, AI likes to add a lot of unnecessary CSS, and you should generally try to delete as much of it as you can. It's amazing how many problems you can fix by deleting CSS other people (or machines) wrote.

Also it says "All Appointments Appointments".

Look for reference at the service queues one. The top bar there is white rather than grey, but we can still get some sense of how the elements are supposed to look together:

Try to make it look decent.

Independent of this PR we should open a conversation with Ciarán, since Appointments has diverged substantially from the designs, but also the designs don't have a search bar at all, nor any filters.

brandones

Make it not look bad

…statuses-in-one-big-appointments-table-remove-status-selector-bar-add-status-filter-dropdown

…-one-big-appointments-table-remove-status-selector-bar-add-status-filter-dropdown' of https://github.com/EDSONZ-WASSWA/openmrs-esm-patient-management into O3-4814-appointments-show-patients-with-all-statuses-in-one-big-appointments-table-remove-status-selector-bar-add-status-filter-dropdown

EDSONZ-WASSWA · 2025-12-09T22:51:10Z

Make it not look bad
@brandones I have removed the unnecessary scss as you requested,
hope this looks good

I tried following the service queues fully

brandones · 2025-12-10T14:17:43Z

That is improved. A lot of what makes it look bad, you'll notice, is the bottom border getting chopped off:

The bottom border should be continuous up until the Download button.

EDSONZ-WASSWA · 2025-12-10T16:08:01Z

That is improved. A lot of what makes it look bad, you'll notice, is the bottom border getting chopped off:
The bottom border should be continuous up until the Download button.

@brandones any more fix needed here?

brandones · 2025-12-10T16:53:42Z

Why is 'expected' lower case now?

brandones · 2025-12-10T16:55:28Z

Please look at the results yourself and ask yourself, "Do I see any problems? Does the text look right?" and then if you do not see problems, post here. Please don't make me identify obvious issues for you.

…ith-all-statuses-in-one-big-appointments-table-remove-status-selector-bar-add-status-filter-dropdown

EDSONZ-WASSWA · 2025-12-10T23:09:51Z

Why is 'expected' lower case now?

@brandones I have taken time to go throughout everything. I do not expect any error or wrong spelling

I think it's ready to merge

jwnasambu · 2025-12-15T08:09:29Z

packages/esm-appointments-app/src/appointments/scheduled/appointments-list.component.tsx

-  status?: string;
+  status?: string | null;
  title: string;
+  // Optional props for status dropdown (I passed from Extension state)


Kindly this comment doesn’t add value at this point. Please remove it to improve code readability.

jwnasambu · 2025-12-15T08:10:20Z

...ges/esm-appointments-app/src/appointments/common-components/appointments-table.component.tsx

+      location: appointment.location?.name ?? '--',
+      provider: appointment.providers?.[0]?.name ?? '--',
+      status: <AppointmentActions appointment={appointment} />,
+      _appointment: appointment, // for expansion


jwnasambu · 2025-12-15T08:11:39Z

packages/esm-appointments-app/src/appointments/scheduled/scheduled-appointments.component.tsx

+    shouldShow ? showExtensionTab(extension.name) : hideExtensionTab(extension.name);
  }, [extension, dateType, showExtensionTab, hideExtensionTab]);

+  // When "all" is selected, show only the first extension with null status to get all appointments


jwnasambu · 2025-12-15T08:12:02Z

packages/esm-appointments-app/src/hooks/useAppointmentList.ts

+      startDate: startDate,
+      endDate: endDate,
+    };
+    // .Only include status in request body if it's not null/undefined


brandones · 2025-12-15T15:18:36Z

Thanks @jwnasambu . The code looks really bad, tons of prop threading etc. But before we rework it I'm waiting to hear back from Palladium about whether we actually need this "ExtensionWrapper" stuff. Hopefully we can just get rid of it and simplify all this code a lot. https://openmrs.slack.com/archives/C039BLMGMMX/p1765473129593799

…statuses-in-one-big-appointments-table-remove-status-selector-bar-add-status-filter-dropdown

chibongho · 2026-02-23T18:04:08Z

Thanks @jwnasambu . The code looks really bad, tons of prop threading etc. But before we rework it I'm waiting to hear back from Palladium about whether we actually need this "ExtensionWrapper" stuff. Hopefully we can just get rid of it and simplify all this code a lot. https://openmrs.slack.com/archives/C039BLMGMMX/p1765473129593799

I think enough time has passed that we should just get rid of the ExtensionWrapper. IIRC, it's used to determine whether the "Expected / Competed / Missed Appointments" tabs should be displayed. With this PR merging them all into one big table (with filter), I don't think we need it anymore.

…statuses-in-one-big-appointments-table-remove-status-selector-bar-add-status-filter-dropdown

chibongho

This needs more work:

There are compilation errors.
- I don't think we can define additional fields like _appointment field for the row object. (I'd love for that to be the case though)
Remove <ExtensionWrapper> and its corresponding <ExtensionSlot>, since those were only needed to support the different tabs, which are going away.
Remove this whole schema that configures the tabs, since those are no longer in place.
Figure out what to do with the "Early appointments" tab. See ticket comment.
Figure out whether to have the filter selections be sticky across date switch / page refresh. See ticket comment.
The "empty state" that we show within a table looks different than the one in the queues table. See screenshots.
- To be fair, I'm not 100% sure which one is the one we want. But right, now it has extra white padding, and the message "to display to display" is incorrect.

denniskigen requested a review from brandones December 8, 2025 11:56

EDSONZ-WASSWA closed this Dec 8, 2025

EDSONZ-WASSWA force-pushed the O3-4814-appointments-show-patients-with-all-statuses-in-one-big-appointments-table-remove-status-selector-bar-add-status-filter-dropdown branch from ae88d96 to cb4687c Compare December 8, 2025 21:06

EDSONZ-WASSWA added 2 commits December 9, 2025 00:09

O3-4814-show-appointments

50d822b

Added the All status option

ca9e19a

EDSONZ-WASSWA reopened this Dec 8, 2025

Merge branch 'main' into O3-4814-appointments-show-patients-with-all-…

084b9a7

…statuses-in-one-big-appointments-table-remove-status-selector-bar-add-status-filter-dropdown

brandones requested changes Dec 9, 2025

View reviewed changes

EDSONZ-WASSWA added 5 commits December 10, 2025 00:50

Merge branch 'main' into O3-4814-appointments-show-patients-with-all-…

c314701

…statuses-in-one-big-appointments-table-remove-status-selector-bar-add-status-filter-dropdown

O3-4814-show-appointments

ab73201

Added the All status option

2765973

removed unnecessary scss

6e92e98

EDSONZ-WASSWA requested a review from brandones December 9, 2025 22:51

Worked on the search bar

13027e4

EDSONZ-WASSWA added 5 commits December 10, 2025 21:59

Merge branch 'openmrs:main' into O3-4814-appointments-show-patients-w…

adac53b

…ith-all-statuses-in-one-big-appointments-table-remove-status-selector-bar-add-status-filter-dropdown

Merge branch 'openmrs:main' into O3-4814-appointments-show-patients-w…

446d697

…ith-all-statuses-in-one-big-appointments-table-remove-status-selector-bar-add-status-filter-dropdown

O3-4814-show-appointments

951acd2

Added the All status option

56967a5

removed bottom color on search and expected to start with Capital

99e92fd

jwnasambu reviewed Dec 15, 2025

View reviewed changes

EDSONZ-WASSWA force-pushed the O3-4814-appointments-show-patients-with-all-statuses-in-one-big-appointments-table-remove-status-selector-bar-add-status-filter-dropdown branch from 0e6a7b7 to 99e92fd Compare December 18, 2025 18:32

EDSONZ-WASSWA added 2 commits December 18, 2025 22:21

Removed unnecesary comments

f965c74

Merge branch 'main' into O3-4814-appointments-show-patients-with-all-…

64a8dd4

…statuses-in-one-big-appointments-table-remove-status-selector-bar-add-status-filter-dropdown

EDSONZ-WASSWA mentioned this pull request Dec 22, 2025

(feat) O3-4815: Filter appointments table by service and status dropdown fields #1987

Closed

3 tasks

brandones mentioned this pull request Feb 19, 2026

(fix) O3-5368 Appointments - make appointment table always show rows … #2275

Merged

3 tasks

Merge branch 'main' into O3-4814-appointments-show-patients-with-all-…

99f79d5

…statuses-in-one-big-appointments-table-remove-status-selector-bar-add-status-filter-dropdown

chibongho requested changes Feb 24, 2026

View reviewed changes

Conversation

EDSONZ-WASSWA commented Dec 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Requirements

Summary

Screenshots

Related Issue

Other

Uh oh!

denniskigen commented Dec 8, 2025

Uh oh!

brandones commented Dec 8, 2025

Uh oh!

EDSONZ-WASSWA commented Dec 8, 2025

Uh oh!

brandones commented Dec 9, 2025

Uh oh!

brandones left a comment

Choose a reason for hiding this comment

Uh oh!

EDSONZ-WASSWA commented Dec 9, 2025

Uh oh!

brandones commented Dec 10, 2025

Uh oh!

EDSONZ-WASSWA commented Dec 10, 2025

Uh oh!

brandones commented Dec 10, 2025

Uh oh!

brandones commented Dec 10, 2025

Uh oh!

EDSONZ-WASSWA commented Dec 10, 2025

Uh oh!

jwnasambu Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

jwnasambu Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

jwnasambu Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

jwnasambu Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

brandones commented Dec 15, 2025

Uh oh!

chibongho commented Feb 23, 2026

Uh oh!

chibongho left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

EDSONZ-WASSWA commented Dec 5, 2025 •

edited

Loading

chibongho left a comment •

edited

Loading