add kv cache name env var to docs + fix a couple errors #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vicb
approved these changes
Oct 10, 2024
|
|
||
| #### 2. Add the KV namespace to your Worker | ||
|
|
||
| The binding name used in your app's worker will be `NEXT_CACHE_WORKERS_KV` by default. This is configurable and can be changed by setting the `__OPENNEXT_KV_BINDING_NAME` build-time environment variable. |
There was a problem hiding this comment.
What about re-using <YOUR_NAMESPACE_NAME> and add a note about the default value at the bottom of this section.
There was a problem hiding this comment.
the binding name can differ from the namespace name (and maybe should if you have multiple next.js apps or preview vs prod), so i'm not sure that would be the right recommendation
dario-piotrowicz
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__OPENNEXT_KV_BINDING_NAMEenv var.