Skip to content

Conversation

dario-piotrowicz
Copy link
Contributor

No description provided.

@dario-piotrowicz
Copy link
Contributor Author

@conico974 sorry my bad! now it should be all good 😓

Copy link

pkg-pr-new bot commented Oct 10, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/aws@543

commit: 0f3bad1

@conico974
Copy link
Contributor

Don't worry no problem.
It's stil a 404 though

@conico974
Copy link
Contributor

Hoo might be related to this : stackblitz-labs/pkg.pr.new#259 (comment)

I think we need to wait for the next release for it to work well

@dario-piotrowicz
Copy link
Contributor Author

I think we need to wait for the next release for it to work well

ahhhh! ok good find! 👍

yeah I guess it's probably that

Copy link
Contributor

@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fine, we'll wait for the next release.
In the meantime we just have to look into stackblitz to get the correct url.

Thanks for that

"repository": {
"type": "git",
"url": "git@github.com:opennextjs/opennextjs-aws.git",
"url": "git+https://github.com:opennextjs/opennextjs-aws.git",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dario-piotrowicz Wait is this correct actually ?
The one in cloudflare is just this "url": "https://github.com/opennextjs/opennextjs-cloudflare.git"
Maybe that's why it doesn't work

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mh... git+ should be correct as that what's included in the npm docs: https://docs.npmjs.com/cli/v10/configuring-npm/package-json#repository
🤔

I'm happy to give the http version a go too, I think that they're likely both valid

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@conico974 yeah the longer version is not helping, I do think we just need to wait for the next release 😕

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was worth a try.
Ok i'll merge this then, we can revisit this if it still don't work on next release

@conico974 conico974 merged commit 6359c50 into main Oct 10, 2024
3 checks passed
@conico974 conico974 deleted the dario/package-json-repo branch October 10, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants