-
Notifications
You must be signed in to change notification settings - Fork 176
update repositry details in @opennextjs/aws
package.json
#543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@conico974 sorry my bad! now it should be all good 😓 |
commit: |
Don't worry no problem. |
Hoo might be related to this : stackblitz-labs/pkg.pr.new#259 (comment) I think we need to wait for the next release for it to work well |
ahhhh! ok good find! 👍 yeah I guess it's probably that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's fine, we'll wait for the next release.
In the meantime we just have to look into stackblitz to get the correct url.
Thanks for that
packages/open-next/package.json
Outdated
"repository": { | ||
"type": "git", | ||
"url": "git@github.com:opennextjs/opennextjs-aws.git", | ||
"url": "git+https://github.com:opennextjs/opennextjs-aws.git", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dario-piotrowicz Wait is this correct actually ?
The one in cloudflare is just this "url": "https://github.com/opennextjs/opennextjs-cloudflare.git"
Maybe that's why it doesn't work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mh... git+
should be correct as that what's included in the npm docs: https://docs.npmjs.com/cli/v10/configuring-npm/package-json#repository
🤔
I'm happy to give the http version a go too, I think that they're likely both valid
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@conico974 yeah the longer version is not helping, I do think we just need to wait for the next release 😕
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was worth a try.
Ok i'll merge this then, we can revisit this if it still don't work on next release
6d2d69e
to
4449b49
Compare
No description provided.