Skip to content

update repositry details in @opennextjs/aws package.json #543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 10, 2024
Merged

update repositry details in @opennextjs/aws package.json #543

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
90e6dcd
update repositry details in `@opennextjs/aws` package.json
dario-piotrowicz Oct 10, 2024
40f36f4
fix wrong repo url
dario-piotrowicz Oct 10, 2024
4449b49
try to use http version of repository url
dario-piotrowicz Oct 10, 2024
0f3bad1
remove unnecessary .git
dario-piotrowicz Oct 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/open-next/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@
},
"repository": {
"type": "git",
"url": "git+https://github.com/sst/open-next.git"
"url": "git+https://github.com:opennextjs/opennextjs-aws.git",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dario-piotrowicz Wait is this correct actually ?
The one in cloudflare is just this "url": "https://github.com/opennextjs/opennextjs-cloudflare.git"
Maybe that's why it doesn't work

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mh... git+ should be correct as that what's included in the npm docs: https://docs.npmjs.com/cli/v10/configuring-npm/package-json#repository
🤔

I'm happy to give the http version a go too, I think that they're likely both valid

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@conico974 yeah the longer version is not helping, I do think we just need to wait for the next release 😕

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was worth a try.
Ok i'll merge this then, we can revisit this if it still don't work on next release

"directory": "packages/open-next"
}
}
Loading