- 
                Notifications
    You must be signed in to change notification settings 
- Fork 178
make sure edge function entries are properly awaited #704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| 🦋 Changeset detectedLatest commit: e4c87e3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
 Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR | 
| commit:  | 
ddc1848    to
    6d87f6f      
    Compare
  
    | Coverage Report
 File Coverage
 | ||||||||||||||||||||||||||||||||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thanks.
Could you just add a changeset though ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Is there a simple way to add a test?
| 
 Thanks 🙂, sorry my bad, here I've added one: e4c87e3 let me know if it's ok or if it should contain more details 🙂 | 
| 
 good point, let me have a look 👍 | 
| 
 Since this relates to the code we get from Next.js itself I don't think it makes sense to unit test it, an e2e would make sense to me here, however the e2e tests setup here is pretty involved and it'd take me a while to get it done 😓 @conico974 has been kind enough to offering to add an e2e test for this in a followup PR (thanks a lot @conico974! ❤️ ) so if everyone is ok with it I'd say to just merge the PR as is 😄 | 
the values in
self._ENTRIEScan be promises so they need to be awaited before using them, AFAICT that's also what Next.js does: source codethis PR makes sure that such values are properly awaited