Skip to content

make sure edge function entries are properly awaited #704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 20, 2025
Merged

make sure edge function entries are properly awaited #704

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d87f6f
make sure edge function entries are properly awaited
dario-piotrowicz Jan 20, 2025
e4c87e3
add missing changeset
dario-piotrowicz Jan 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/smart-carrots-build.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@opennextjs/aws": patch
---

fix: make sure edge function entries are properly awaited
6 changes: 3 additions & 3 deletions packages/open-next/src/core/edgeFunctionHandler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@ export default async function edgeFunctionHandler(
throw new Error(`No route found for ${request.url}`);
}

const result = await self._ENTRIES[
`middleware_${correspondingRoute.name}`
].default({
const entry = await self._ENTRIES[`middleware_${correspondingRoute.name}`];

const result = await entry.default({
page: correspondingRoute.page,
request: {
...request,
Expand Down
14 changes: 8 additions & 6 deletions packages/open-next/src/types/global.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,13 +37,15 @@ export interface RequestData {
signal: AbortSignal;
}

interface Entry {
default: (props: { page: string; request: RequestData }) => Promise<{
response: Response;
waitUntil: Promise<void>;
}>;
}

interface Entries {
[k: string]: {
default: (props: { page: string; request: RequestData }) => Promise<{
response: Response;
waitUntil: Promise<void>;
}>;
};
[k: string]: Entry | Promise<Entry>;
}

export interface EdgeRoute {
Expand Down
Loading