-
Couldn't load subscription status.
- Fork 177
trace node packages #835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
trace node packages #835
Conversation
🦋 Changeset detectedLatest commit: b218400 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
That's a good idea yeah. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thanks
|
Thanks for the review Nico! |
|
@vicb Later today, just let me know if you want to add something in it |
In the cloudflare adapter, we want to copy files used via the "workerd" build conditions.
To be able to do this this PR updates
copyTracedFilesto return a map of traced node packages.It maps the original path of the package to the path in
.open-next.As a follow up, we might integrate that better with the patch system.
Today,
applyCodePatchesassumes that a patch will update file content.We could modify
applyCodePatchesto take a list ofPatch.The
Patchclass would be instantiated withoptions, tracedFiles, manifests, nodePackages, nextVersionand have a publicapplymethod.We could then have derived
PatchFileContent,PatchCopyFile, ... classes.