add(patches): Drop babel from getting pulled in by node-environment #948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6879b38 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
|
cc @vicb |
vicb
reviewed
Aug 4, 2025
packages/tests-unit/tests/build/patch/patches/patchNodeEnvironment.test.ts
Outdated
Show resolved
Hide resolved
vicb
approved these changes
Aug 4, 2025
|
Thanks for the review Victor! |
vicb
reviewed
Aug 5, 2025
packages/open-next/src/build/patch/patches/patchNodeEnvironment.ts
Outdated
Show resolved
Hide resolved
…t.ts Co-authored-by: Victor Berchet <[email protected]>
Merged
vicb
added a commit
to opennextjs/opennextjs-cloudflare
that referenced
this pull request
Sep 1, 2025
`patchNodeEnvironment` was introduced in #843 to drop the babel dependency. It was upstream into aws via opennextjs/opennextjs-aws#948. This PR drops the local version to use the upstream version.
vicb
added a commit
to opennextjs/opennextjs-cloudflare
that referenced
this pull request
Sep 1, 2025
`patchNodeEnvironment` was introduced in #843 to drop the babel dependency. It was upstream into aws via opennextjs/opennextjs-aws#948. This PR drops the local version to use the upstream version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #947
I applied it on
>=15.0.0.