Skip to content

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Oct 8, 2025

@vicb vicb requested a review from conico974 October 8, 2025 09:07
Copy link

changeset-bot bot commented Oct 8, 2025

🦋 Changeset detected

Latest commit: db4fb19

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@opennextjs/aws Minor
app-pages-router Patch
app-router Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 8, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 28.35% 2844 / 10029
🔵 Statements 28.35% 2844 / 10029
🔵 Functions 52.66% 148 / 281
🔵 Branches 76.22% 715 / 938
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/open-next/src/http/openNextResponse.ts 1.39% 0% 0% 1.39% 20-419
Generated in workflow #1534 for commit db4fb19 by the Vitest Coverage Report Action

Copy link

pkg-pr-new bot commented Oct 8, 2025

Open in StackBlitz

pnpm add https://pkg.pr.new/@opennextjs/aws@992

commit: db4fb19

@vicb
Copy link
Contributor Author

vicb commented Oct 8, 2025

We should probably keep track of pushes for the AWS hack in _flush.

I'll update this PR when #991 is merged.
We could have a private bodyLength = 0 updated when chunks are pushed and used that in _flush

@vicb vicb marked this pull request as draft October 8, 2025 09:31
@vicb vicb force-pushed the vicb/stream-no-chunks branch from 624dce5 to dcfdb88 Compare October 8, 2025 11:16
@vicb vicb marked this pull request as ready for review October 8, 2025 11:17
@vicb vicb merged commit 6a96ac8 into main Oct 8, 2025
3 checks passed
@vicb vicb deleted the vicb/stream-no-chunks branch October 8, 2025 11:44
@github-actions github-actions bot mentioned this pull request Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants