Skip to content

[WIP] add patches to support nodejs.org #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[WIP] add patches to support nodejs.org #141

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions packages/cloudflare/src/cli/build/bundle-server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,24 @@ globalThis.__dangerous_ON_edge_converter_returns_request = true;
console.log(`\x1b[35mWorker saved in \`${openNextServerBundle}\` 🚀\n\x1b[0m`);
}

/**
* Next.js sets this `__import_unsupported` on `globalThis`:
* https://github.com/vercel/next.js/blob/5b7833e3/packages/next/src/server/web/globals.ts#L94-L98
*
* For some reason on us this gets run more than once causing a `Cannot redefine property: __import_unsupported`
* runtime error.
*
* So here we patch the function to only define the property if it is not already there
*
* TODO: this should ideally be done in a more robust way with ts-morph
*/
export function patchEnhanceGlobals(code: string) {
return code.replace(
`Object.defineProperty(globalThis, "__import_unsupported",`,
`if(!("__import_unsupported" in globalThis)) Object.defineProperty(globalThis, "__import_unsupported",`
);
}

/**
* This function applies string replacements on the bundled worker code necessary to get it to run in workerd
*
Expand All @@ -164,6 +182,7 @@ async function updateWorkerBundledCode(
patchedCode = await patchCache(patchedCode, openNextOptions);
patchedCode = inlineMiddlewareManifestRequire(patchedCode, config);
patchedCode = patchExceptionBubbling(patchedCode);
patchedCode = patchEnhanceGlobals(patchedCode);

patchedCode = patchedCode
// workers do not support dynamic require nor require.resolve
Expand Down
Loading