Skip to content

Conversation

dario-piotrowicz
Copy link
Contributor

@dario-piotrowicz dario-piotrowicz commented Nov 22, 2024

I'm trying to see if we could run the nodejs.org website using our adaptor, as part of that I am opening this PR that introduces some patches that seem necessary to support the nodejs.org website.

I'm opening this PR now mainly to get a pkg.pr.new package so that I can share my progress with others.

(but the changes here might be generally needed/valid)

See #160

Copy link

changeset-bot bot commented Nov 22, 2024

⚠️ No Changeset found

Latest commit: a7f7651

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

pkg-pr-new bot commented Nov 22, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/cloudflare@141

commit: a7f7651

@vicb vicb mentioned this pull request Dec 10, 2024
Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

could you please rebase?

Thanks!

@dario-piotrowicz
Copy link
Contributor Author

dario-piotrowicz commented Dec 12, 2024

@vicb I wanted to look into the patch for the instrumentation issue a bit more properly, so I opened #169 for that instead, I hope you don't mind 🙏

(and I removed the patch from this PR)

@dario-piotrowicz
Copy link
Contributor Author

Closing this PR since the issues addressed here have been fixed in #169 and #182

@dario-piotrowicz dario-piotrowicz deleted the dario/experimental/nodejsorg-support branch December 16, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants