-
Notifications
You must be signed in to change notification settings - Fork 73
temporary patch the loadInstrumentationModule
methods to support Next.js 15
#169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
commit: |
Note I wanted to use ts-morph to make the replacement more robust.... only after applying it I actually looked into the instrumentation docs and understood that this is a temporary workaround 😓, so the regex replacement I had in #141 was actually good enough 😓, I am happy to revert to that if people prefer that for such a temporary workaround |
Note I think this change is valuable for unblocking Next.js 15, I will still look into what a potential proper fix for #160 should look like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I have added a minor comment. Please move the existing issue to the experimental column of the board when you merge this.
Thanks! |
resolves #160
This PR patches the bundled worker code by removing the content of all the problematic
loadInstrumentationModule
methods.Such removal however most likely breaks Next.js' instrumentation, so I think that it should just be considered a temporary workaround for supporting Next.js 15.