Skip to content

Conversation

dario-piotrowicz
Copy link
Contributor

@dario-piotrowicz dario-piotrowicz commented Dec 12, 2024

resolves #160


This PR patches the bundled worker code by removing the content of all the problematic loadInstrumentationModule methods.

Such removal however most likely breaks Next.js' instrumentation, so I think that it should just be considered a temporary workaround for supporting Next.js 15.

Copy link

changeset-bot bot commented Dec 12, 2024

⚠️ No Changeset found

Latest commit: da55ad4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

pkg-pr-new bot commented Dec 12, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/cloudflare@169

commit: c552305

@dario-piotrowicz
Copy link
Contributor Author

Note

I wanted to use ts-morph to make the replacement more robust.... only after applying it I actually looked into the instrumentation docs and understood that this is a temporary workaround 😓, so the regex replacement I had in #141 was actually good enough 😓, I am happy to revert to that if people prefer that for such a temporary workaround

@dario-piotrowicz
Copy link
Contributor Author

Note

I think this change is valuable for unblocking Next.js 15, I will still look into what a potential proper fix for #160 should look like

Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I have added a minor comment. Please move the existing issue to the experimental column of the board when you merge this.

@vicb vicb merged commit 429e880 into experimental Dec 13, 2024
2 checks passed
@vicb vicb deleted the dario/experimental/160/instrumentation branch December 13, 2024 07:38
@vicb
Copy link
Contributor

vicb commented Dec 13, 2024

Thanks!
I moved #160 to the done in experimental column of the board.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants