make sure all code patch steps are validated #186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
commit: |
improve the code patching validation by removing the validation for each single patch function and introducing a new `patchCodeWithValidations` that applies all the patches with validations all in a single place
dario-piotrowicz
force-pushed
the
dario/experimental/28/patch-validations
branch
from
abc70d6 to
3f5e87a
Compare
vicb
pushed a commit
that referenced
this pull request
Dec 20, 2024
make sure all code patch steps are validated and improve the code patching validation by removing the validation for each single patch function and introducing a new `patchCodeWithValidations` that applies all the patches with validations all in a single place
vicb
pushed a commit
that referenced
this pull request
Dec 20, 2024
make sure all code patch steps are validated and improve the code patching validation by removing the validation for each single patch function and introducing a new `patchCodeWithValidations` that applies all the patches with validations all in a single place
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #28
This PR makes sure that all our code patches are applied (that they do change the worker's code)
As part of this I did a bit of refactoring to remove every single function's log and validation and consolidate then
in a single function
patchCodeWithValidationsThe result/logs in case everything works as expected:
The result/logs in case a step fails:
