-
Notifications
You must be signed in to change notification settings - Fork 73
feat: r2 adapter for the incremental cache #443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 33c238b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
ced3fcf
to
de7e0bb
Compare
de7e0bb
to
76e2c5d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one little comment, i guess the only thing remaining is what to do for #436
Yeah I think the main outstanding questions are;
I was hoping to be able to talk about those this week, but didn't realise that the meeting time was changing 😓. Hopefully Victor might have a chance to take a look at the PRs at some point, otherwise we can discuss next week I guess, but I was hoping to have wrapped up the population one by now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a few nits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a small comment
This PR is based off of #436 to enable auto-populating of the cache entries.
Changes
Discussion points
This is part 2 of 3 in a stack made with GitButler: