-
Notifications
You must be signed in to change notification settings - Fork 73
feat: commands for cli actions #479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: conico974 <[email protected]>
🦋 Changeset detectedLatest commit: a147d77 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
3a7797f
to
8deefe5
Compare
0f9964c
to
40e86f1
Compare
40e86f1
to
2247ed4
Compare
1ef9765
to
bf9d7da
Compare
c2a6a12
to
631ce29
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I just have a small question.
@james-elicx The new commands for cli is great but there is no documentation for the breaking change. Following the documentation here it will shot just your feet with:
and
And error log in Cloudflare worker shows:
|
OK. I found the solution in the readme file: https://github.com/opennextjs/opennextjs-cloudflare/pull/479/files#diff-be36604f10bbd9205e3930ca4cdb26388354a780fe7a8407735067cbff7694ec The deploy script now should be:
|
Hi @chrox, sorry for the delay between when this release shipped and when the docs PR was merged - it was updated shortly after your comment was left here. |
I appreciate the update! Thanks for getting the docs merged and for following up. |
This is part 3 of 3 in a stack made with GitButler: