add(feature): Make request.signal.onabort work in route handlers #847
+504
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8b953f3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress, therefor its still in Draft mode:
IncomingMessage. Is it possible to patch this aswell? Investigate this. Its not supported innext startBTW. So we would have to override the type aswell.Should close #691
On May 22, 2025 Cloudflare added this to workers:
https://developers.cloudflare.com/changelog/2025-05-22-handle-request-cancellation/
By patching this method from Next I figured out we might be able to use it for passing in the original signal from the workers
Request. This turned out to be true.Thanks to our beloved @conico974 for teaching me some
ast-grep:) Rule number one:smallest to biggest.Any suggestions on how to E2E this the proper way are more than welcome!