Skip to content

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Aug 25, 2025

No description provided.

Copy link

changeset-bot bot commented Aug 25, 2025

🦋 Changeset detected

Latest commit: 7aebe91

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@opennextjs/cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Aug 25, 2025

Open in StackBlitz

npm i https://pkg.pr.new/@opennextjs/cloudflare@858

commit: 7aebe91

@vicb
Copy link
Contributor Author

vicb commented Aug 25, 2025

Thanks for the reviews!
Look like there is a legit issue, I'll investigate

@sommeeeer
Copy link
Collaborator

sommeeeer commented Aug 25, 2025

https://github.com/opennextjs/opennextjs-cloudflare/blob/c882339/examples/e2e/app-router/app/api/after/ssg/route.ts

This test might need to change into a page. The Cache Interceptor will return the prerendered data for a static route everytime which is correct according to Next docs.

Currently it should not be supported to revalidate a route handler that is force-static. If you next start the app-router you will see that its not possible to revalidate that route by sending a POST to api/after/revalidate.

By reading here they are claiming under force-static that it should only be possible to revalidate pages or layouts. Maybe we should turn that test into being a page.tsx instead?

@conico974
Copy link
Collaborator

It's a bug here https://github.com/opennextjs/opennextjs-aws/blob/9a83eb754ca82f830b1cc06d2d1470cd19173e0b/packages/open-next/src/core/routing/cacheInterceptor.ts#L231
We should check route type here as well

@vicb
Copy link
Contributor Author

vicb commented Aug 27, 2025

The issue was fixed in opennextjs/opennextjs-aws#959.

We will bump to the next aws release when available

@vicb vicb changed the title bump @opennextjs/aws to 3.7.5 bump @opennextjs/aws to 3.7.6 Sep 1, 2025
@vicb
Copy link
Contributor Author

vicb commented Sep 1, 2025

Updated the PR to use aws 3.7.6

@vicb
Copy link
Contributor Author

vicb commented Sep 1, 2025

Thank everybody for the review/help getting this in!

@vicb vicb merged commit 7233c03 into main Sep 1, 2025
7 checks passed
@vicb vicb deleted the vicb/aws-3.7.5 branch September 1, 2025 06:58
timReynolds pushed a commit to timReynolds/opennextjs-cloudflare that referenced this pull request Sep 21, 2025
* sync opennextjs#858

* sync aws#851

* sync aws#844 and aws#855

* linting

* bump to aws 3.6.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants