Skip to content

refactor: make kv tag cache logs more correct / less verbose #920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2025
Merged

refactor: make kv tag cache logs more correct / less verbose #920

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions packages/cloudflare/src/api/overrides/tag-cache/kv-next-tag-cache.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,17 @@ export class KVNextModeTagCache implements NextModeTagCache {
readonly name = NAME;

async getLastRevalidated(tags: string[]): Promise<number> {
const timeMs = await this.#getLastRevalidated(tags);
debugCache("KVNextModeTagCache", `getLastRevalidated tags=${tags} -> time=${timeMs}`);
return timeMs;
}

/**
* Implementation of `getLastRevalidated`.
*
* This implementation is separated so that `hasBeenRevalidated` do not include logs from `getLastRevalidated`.
*/
async #getLastRevalidated(tags: string[]): Promise<number> {
const kv = this.getKv();
if (!kv || tags.length === 0) {
return 0;
Expand All @@ -36,10 +47,7 @@ export class KVNextModeTagCache implements NextModeTagCache {
const result: Map<string, number | null> = await kv.get(keys, { type: "json" });

const revalidations = [...result.values()].filter((v) => v != null);

const timeMs = revalidations.length === 0 ? 0 : Math.max(...revalidations);
debugCache("KVNextModeTagCache", `getLastRevalidated tags=${tags} -> time=${timeMs}`);
return timeMs;
return revalidations.length === 0 ? 0 : Math.max(...revalidations);
} catch (e) {
// By default we don't want to crash here, so we return false
// We still log the error though so we can debug it
Expand All @@ -49,7 +57,7 @@ export class KVNextModeTagCache implements NextModeTagCache {
}

async hasBeenRevalidated(tags: string[], lastModified?: number): Promise<boolean> {
const revalidated = (await this.getLastRevalidated(tags)) > (lastModified ?? Date.now());
const revalidated = (await this.#getLastRevalidated(tags)) > (lastModified ?? Date.now());
debugCache(
"KVNextModeTagCache",
`hasBeenRevalidated tags=${tags} lastModified=${lastModified} -> ${revalidated}`
Expand Down