Fix unchanged Quark files appearing in changeset results#7130
Merged
shanman190 merged 3 commits intomainfrom Mar 25, 2026
Merged
Fix unchanged Quark files appearing in changeset results#7130shanman190 merged 3 commits intomainfrom
shanman190 merged 3 commits intomainfrom
Conversation
Quark.printAll() and Binary.printAll() throw UnsupportedOperationException, causing Result.isLocalAndHasNoChanges() to incorrectly report them as changed. Add explicit handling for these types before calling printAll(). Fixes #3948
Member
Author
|
Feel free to immediately merge this if you see it and agree, such that this can make it into the release to fix a long standing issue. |
shanman190
reviewed
Mar 25, 2026
Removed binary file comparison logic from Result class.
shanman190
approved these changes
Mar 25, 2026
shanman190
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Result.isLocalAndHasNoChanges()callsprintAll()to compare before/after, butQuarkthrowUnsupportedOperationExceptionfromprintAll(). The catch block returnsfalse, so unchanged files (e.g..jkskeystores) are incorrectly reported as changed.Add explicit handling: Quarks are compared by source path.
Wrapper update recipes (e.g.
UpdateMavenWrapper) are unaffected because they replaceQuark→Remote, which doesn't match the new Quark-to-Quark check.Fixes UpdateMavenWrapper is reported as changing a lot of files (but it does not) #3948
Test plan
./gradlew :rewrite-core:test)