Fix flaky upgrade-dependency-version test#7242
Merged
knutwannheden merged 2 commits intomainfrom Apr 2, 2026
Merged
Conversation
The test asserted an exact resolved version (4.17.23) for lodash when using a ^4.17.20 constraint, but npm now resolves to 4.18.1. Use semver.satisfies() instead to check that the resolved version satisfies the constraint, making the test resilient to new lodash releases.
Same issue as the upgrade-dependency-version test: the lock file
version assertion used startsWith("4.17.") which breaks now that
lodash 4.18.1 exists. Use semver.satisfies() instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The
UpgradeDependencyVersiontest "skips npm install when resolved version already satisfies new constraint" was asserting thatlodash@^4.17.20resolves to exactly4.17.23. With the release of lodash 4.18.1, npm now resolves it to4.18.1, causing the test to fail on CI.Summary
toBe("4.17.23")) withsemver.satisfies(version, "^4.17.23")so the test is resilient to future lodash releasesTest plan
npx vitest run test/javascript/recipes/upgrade-dependency-version.test.ts -t "skips npm install"— passes